-
Notifications
You must be signed in to change notification settings - Fork 115
Update Notice to include relevant parts from FlexSDK NOTICE file #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As FlexSDK is ALv2 relevant bits in it's notice file need to be propagated to this notice file. See [1] 1. http://www.apache.org/dev/licensing-howto.html#alv2-dep
|
Which dependency do you think requires this change? I can't think of a Flex dependency in asjs that would require this. |
|
It's not a dependancy issue. You copied code from the Flex SDK into the Royale SDK. The Flex SDK is ALv2 licensed and it has a NOTICE file so bits that are important in that NOTICE file need to be copied the the Royale NOTICE file to comply with the Apache license and ASF policy. |
|
I assumed that if you linked to requirements for dependencies you were talking about a dependency requirement. The FlexSDK had those bits because it was a product that came from Adobe. Considering that royale-asjs is a project developed solely within Apache, I don't see a need to include that here, and the text is actually not factually correct. |
|
I assume you would agree that the MX Validation class (which have been copied into this branch from the Flex SDK) were written by people at Adobe? |
|
Two points. (1) The PR has an extra copyright for the ASF added. This would need to be removed from the PR. (2) The inclusion of the following: The Initial Developer of the Original Code, known as Adobe Flex, is Adobe Systems Incorporated (http://www.adobe.com/). This is debatable, It is debatable in both Flex and Royale. I think that the debate is more about the inclusive “The Initial Developer …” Better language would be something like: “Includes software developed and distributed as Adobe Flex. |
|
I agree on both points. I'd personally be okay with the "better language" although I don't see the need to include anything. |
|
The NOTICE files in other Royale repos already contains similar "original developer" language and try to distinguish that not all of the code base was originally developed by Adobe. IMO, we should try to quickly agree on language to make that same distinction for the royale-asjs repo. I suggest:
I suggest this because I would like to avoid spending energy listing out every single place that was somehow influenced by Adobe code, give Adobe proper attribution per the Flex NOTICE language, and distinguish that lots of code was written at Apache. Dave's "includes" suggestion sounds more like a bundling which doesn't feel right to me. |
|
Alex your language should be fine. |
|
There's an extra "the" in the first line:
Otherwise the wording looks fine to me. |
|
Removed the extra "the" and added two "from" and a comma. |
As FlexSDK is ALv2 relevant bits in it's notice file need to be propagated to this notice file. See [1]