emulation components add and/or modified #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2018 11:18
Contributor
|
Looks good. It looked like at least one file had a [ResourceBundle] metadata that wasn't commented out. It would be best to comment them out until we get ResourceBundle working somehow in JS. If you can take a minute to check for and comment out [ResourceBundle] usage then we should be ok to accept this. |
Contributor
Author
|
Yes ı can comment. I checked for the compile errors but all the sources compile without error.
Is it neccessary to remove RB ?
On Tue, Oct 9, 2018 at 7:10 PM +0300, "aharui" <notifications@github.com> wrote:
Looks good. It looked like at least one file had a [ResourceBundle] metadata that wasn't commented out. It would be best to comment them out until we get ResourceBundle working somehow in JS.
If you can take a minute to check for and comment out [ResourceBundle] usage then we should be ok to accept this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
|
The SWC will compile, but the application that uses those classes will report an error about missing bundles right now, so we are commenting out all RB metadata for now. If you can comment out the RB metadata, it will also help ensure that your pull-request workflow is set up correctly. We had some other early contributors have trouble with updating a PR. |
ResourceBundle declaration commented out
Contributor
Author
|
Completed @aharui. You can check it. |
Contributor
|
Thanks and congratulations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.