SAMZA-2230: Support for ANY type arguments in udfs that expect strongly typed arguments#1060
Merged
Conversation
atoomula
approved these changes
May 31, 2019
weiqingy
reviewed
May 31, 2019
| @SamzaSqlUdf(name = "MyTestObj", description = "Test UDF.") | ||
| public class MyTestObjUdf implements ScalarUdf { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(MyTestUdf.class); |
Contributor
There was a problem hiding this comment.
Why we use MyTestUdf.class here? What is the relationship between "MyTestObjUdf" class and MyTestUdf class? I saw the method execute(Object value) is deleted from MyTestUdf class.
Contributor
Author
There was a problem hiding this comment.
This was a mistake, I will fix this. there is no relationship between MyTestUdf and MyTestObj. the deleted method in MyTestUDF was unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calcite and hence Samza SQL supports untyped fields of type SamzaSqlFieldType.ANY. Corresponding java type for such fields is Object.
When an UDF expects a strongly typed field and when one of the arguments that is passed is untyped (i.e. ANY ) it fails. And calcite doesn't allow casting the ANY to a well defined type like java does.
To fix this we explicitly cast the untyped arguments to the type that the UDF expects as part of the UDF code generation. Also added a test case that fails without this change.