SAMZA-2234: Passing context to Samza SQL UDFs#1063
Merged
srinipunuru merged 3 commits intoapache:masterfrom Jun 6, 2019
srinipunuru:udf-context.1
Merged
SAMZA-2234: Passing context to Samza SQL UDFs#1063srinipunuru merged 3 commits intoapache:masterfrom srinipunuru:udf-context.1
srinipunuru merged 3 commits intoapache:masterfrom
srinipunuru:udf-context.1
Conversation
srinipunuru
changed the title
celiakung
reviewed
Jun 4, 2019
| /** | ||
| * This method is used to implement the expressions that takes in columns as input and returns multiple values. | ||
| * @param context the context | ||
| * @param context SamzaSqlExecution context |
There was a problem hiding this comment.
nit: the variable name should be 'sqlContext'
and need to add another param on the next line for regular 'context'
atoomula
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change provides ability for the UDFs to access the Samza context. Context is needed by the UDFs for various reasons