SAMZA-2258: Log thread dump when container stop times out during processor rebalancing#1087
Merged
cameronlee314 merged 2 commits intoapache:masterfrom Jun 25, 2019
Merged
Conversation
…essor rebalancing
cameronlee314
commented
Jun 20, 2019
samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java
Show resolved
Hide resolved
Contributor
|
@cameronlee314 |
Contributor
Author
Oops, missed that. Thanks for pointing it out. PR is updated. |
vjagadish1989
approved these changes
Jun 21, 2019
samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java
Show resolved
Hide resolved
shanthoosh
approved these changes
Jun 24, 2019
vjagadish1989
approved these changes
Jun 25, 2019
Contributor
vjagadish1989
left a comment
vjagadish1989
left a comment
There was a problem hiding this comment.
@cameronlee314 we don't require any further state-checks before initiating the thread-dump.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.