Skip to content

SAMZA-2263 : Ensuring store consumers are started & stopped exactly once #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prateekm merged 1 commit into from
Jun 28, 2019
Merged

SAMZA-2263 : Ensuring store consumers are started & stopped exactly once #1094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,8 +629,8 @@ private void restoreStores() {
// initialize each TaskStorageManager
this.taskRestoreManagers.values().forEach(taskStorageManager -> taskStorageManager.initialize());

// Start store consumers
this.storeConsumers.values().forEach(systemConsumer -> systemConsumer.start());
// Start each store consumer once
this.storeConsumers.values().stream().distinct().forEach(systemConsumer -> systemConsumer.start());

// Create a thread pool for parallel restores (and stopping of persistent stores)
ExecutorService executorService = Executors.newFixedThreadPool(this.parallelRestoreThreadPoolSize,
Expand All @@ -657,8 +657,8 @@ private void restoreStores() {

executorService.shutdown();

// Stop store consumers
this.storeConsumers.values().forEach(systemConsumer -> systemConsumer.stop());
// Stop each store consumer once
this.storeConsumers.values().stream().distinct().forEach(systemConsumer -> systemConsumer.stop());

// Now re-create persistent stores in read-write mode, leave non-persistent stores as-is
recreatePersistentTaskStoresInReadWriteMode(this.containerModel, jobContext, containerContext,
Expand Down