Samza-2287: Removing RegEx based matching while parsing the sql statement#1121
Merged
Conversation
srinipunuru
changed the title
gauravrkulkarni
approved these changes
Jul 31, 2019
| LOG.info("Parsed select query {} from sql {}", selectQuery, sql); | ||
| sources = getSourcesFromSelectQuery(sqlSelect); | ||
| } else { | ||
| throw new SamzaException("Sql query is not of the expected format"); |
There was a problem hiding this comment.
nit: not directly related to this PR, but might want to add what the expected format is in the exception message here and below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SamzaSQLQueryParser uses a brittle regEx parsing to fetch the SQL statement from the SQL. Removing this Regex parsing and use the string generated from SqlSelect node.