SAMZA-2294: LocalApplicationRunner support for missing coordinator stream#1130
Merged
xinyuiscool merged 1 commit intoAug 7, 2019
Merged
Conversation
xinyuiscool
approved these changes
Aug 7, 2019
Contributor
xinyuiscool
left a comment
xinyuiscool
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the quick fix!
Contributor
|
@dnishimura Do we know why |
Contributor
Author
@shanthoosh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain standalone configurations do not define a
job.coordinator.systembecause a coordinator stream is not necessary. For example, in PassthroughJobCoordinator configured jobs or integration test jobs might not have this defined. This PR allows support for such scenarios.Added additional unit tests and verified by @xinyuiscool with his testing.
@xinyuiscool - Please take a look when you get a chance.