SAMZA-2309: Remove readFn requirement for remote tables#1144
Merged
xinyuiscool merged 2 commits intoAug 23, 2019
Conversation
xinyuiscool
approved these changes
Aug 23, 2019
Contributor
|
Is there already validation that either read or write fn is present? |
Member
Author
|
@dengpanyin @prateekm Added validations and tests for readFn and writeFn, tests for the new behaviour and updated AsyncRemoteTable and RemoteTable |
Contributor
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dengpan-yin @dengpanyin @xinyuiscool
Removed validation for read table requied