Emitting numPersistentStores instead of num stores with changelog from DiagnosticsManager#1145
Merged
Merged
Conversation
| private static final String STOP_EVENT_LIST_METRIC_NAME = "stopEvents"; | ||
| private static final String CONTAINER_MB_METRIC_NAME = "containerMemoryMb"; | ||
| private static final String CONTAINER_NUM_CORES_METRIC_NAME = "containerNumCores"; | ||
| private static final String CONTAINER_NUM_STORES_WITH_CHANGELOG_METRIC_NAME = "numStoresWithChangelog"; |
Contributor
There was a problem hiding this comment.
Can all readers of this data handle a missing entry for this? Just double checking on compatibility.
Contributor
Author
There was a problem hiding this comment.
Yup, only the asc prototype uses this currently.
| return (int) getStoreNames().stream() | ||
| .map(storeName -> getStorageFactoryClassName(storeName)) | ||
| .filter(factoryName -> factoryName.isPresent()) | ||
| .filter(factoryName -> factoryName.get().equals(PERSISTENT_STORE_FACTORY)) |
Contributor
There was a problem hiding this comment.
This is inconsistent with StoreProperties.isPersistedToDisk. Over there, it is "persisted" if it is not an in-memory store. Should we do the same here?
Contributor
Author
There was a problem hiding this comment.
Ah, yes, I was looking for exactly that.
Had to add a constant because of the module dependency.
rmatharu-zz
commented
Aug 24, 2019
Contributor
Author
rmatharu-zz
left a comment
rmatharu-zz
left a comment
There was a problem hiding this comment.
addressed both the comments.
cameronlee314
approved these changes
Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.