Skip to content

SAMZA-1198: disable the flaky test TestZkBarrierForVersionUpgrade.testZkBarrierForVersionUpgrade#116

Closed
fredji97 wants to merge 3 commits intoapache:masterfrom
fredji97:disableFlaky
Closed

SAMZA-1198: disable the flaky test TestZkBarrierForVersionUpgrade.testZkBarrierForVersionUpgrade#116
fredji97 wants to merge 3 commits intoapache:masterfrom
fredji97:disableFlaky

Conversation

@fredji97
Copy link

@fredji97 fredji97 commented Apr 6, 2017

We are seeing the fails sometimes from this test, disabling it for build success first. See details in SAMZA-1198, and the JIRA for fix is in SAMZA-1193.

Copy link
Contributor

@navina navina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredji97 Can you remove the entire stacktrace from the description of the PR and add a one line description of the problem?
the PR description becomes the summary of the github commit message and we don't want the entire stacktrace for it.

Also, please revise the title of the PR to be of the format "SAMZA- : <title>"

Thanks!

zkServer.teardown();
}

@Ignore("The test is flaky, see SAMZA-1193")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please comment out the @test annotation instead of using Ignore annotation?
I believe last time @santhoshvenkat1988 tried with Ignore, it caused some failures in hudson. We decided that commenting out test annotation and adding a TODO with JIRA number was cleaner. You can talk to @santhoshvenkat1988 or @jmakes on why it failed on hudson.

@fredji97 fredji97 changed the title disable the flaky test TestZkBarrierForVersionUpgrade.testZkBarrierForVersionUpgrade SAMZA-1198 disable the flaky test TestZkBarrierForVersionUpgrade.testZkBarrierForVersionUpgrade Apr 8, 2017
@fredji97 fredji97 changed the title SAMZA-1198 disable the flaky test TestZkBarrierForVersionUpgrade.testZkBarrierForVersionUpgrade SAMZA-1198: disable the flaky test TestZkBarrierForVersionUpgrade.testZkBarrierForVersionUpgrade Apr 8, 2017
Copy link
Contributor

@navina navina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 260414d Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants