Transactional State [3/5]: Made StorageManagerUtil and FileUtil non-static for mocking side effects in tests#1162
Merged
prateekm merged 1 commit intoapache:masterfrom Oct 2, 2019
Conversation
prateekm
force-pushed
the
alo-non-static-util
branch
2 times, most recently
from
58aa0ff to
8ad7da0
Compare
prateekm
changed the title
bharathkumarasubramanian
approved these changes
Sep 20, 2019
bharathkumarasubramanian
left a comment
bharathkumarasubramanian
left a comment
There was a problem hiding this comment.
8ad7da0 commit changes looks good to me.
Feel free to commit it after PR:1160 and PR:1161.
…cts in tests without having to use PowerMock.
prateekm
force-pushed
the
alo-non-static-util
branch
from
8ad7da0 to
5ee2e14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes StorageManagerUtil and FileUtil method to instance methods instead of static methods. Since many of these methods have side effects (modify disk contents), this helps mock their behavior in unit tests without performing actual I/O or using PowerMock.