Samza-2331: Fix java doc of table descriptor for default rate limiter#1168
Merged
lhaiesp merged 3 commits intoapache:masterfrom Sep 25, 2019
Merged
Samza-2331: Fix java doc of table descriptor for default rate limiter#1168lhaiesp merged 3 commits intoapache:masterfrom
lhaiesp merged 3 commits intoapache:masterfrom
Conversation
dengpanyin
reviewed
Sep 24, 2019
| int numTasks = jobModel.getContainers().values().stream() | ||
| .mapToInt(cm -> cm.getTasks().size()) | ||
| .sum(); | ||
| Preconditions.checkArgument(e.getValue() >= numTasks, |
Contributor
There was a problem hiding this comment.
Shall we just warn the user instead of throw exception for this case?
Also change line 120 to be:
double effectiveRate = (double) e.getValue() / numTasks;
Contributor
Author
There was a problem hiding this comment.
Make sense. Turning the calculation into double is the real fix.
Contributor
|
LGTM |
dengpanyin
approved these changes
Sep 25, 2019
lhaiesp
changed the title
prateekm
pushed a commit
to prateekm/samza
that referenced
this pull request
Oct 2, 2019
…apache#1168) Fix java doc of table descriptor for default rate limiter and use double in the rate limit calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing java doc is confusing about what the actual behavior is for the default rate limiter. We should explicitly note that it is for the entire job and per task credit needs to divide that by number of tasks.