[CLOSED] SAMZA-2334: SSPGrouperProxy should check if job is stateful, not if host-affinity is enabled.#1178
Closed
dnishimura wants to merge 2 commits into
Conversation
…ost-affinity is enabled. Also need to add a configuration to disable SSPGrouperProxy to unblock jobs from running.
Contributor
Author
|
Closed to figure out the failing test. |
dnishimura
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
SSPGrouperProxyprovides the capability for input partition counts to expand or contract by a multiple of the previous count. This is only need by stateful jobs. Currently the check for stateful jobs is to see ifhost-affinityis enabled. However, that is the wrong check becausehost-affinitydoes not imply a job is stateful.The fix here is to check to see if the job has any local state stores rather than checking if
host-affinityis enabled. The other part of the fix is to allow disabling theSSPGrouperProxyin the situation where the job cannot expand or contract the input partitions by an appropriate factor.@prateekm @shanthoosh @dxichen