SAMZA-2343: Remove original split deployment code#1182
Merged
cameronlee314 merged 1 commit intoapache:masterfrom Oct 14, 2019
Merged
SAMZA-2343: Remove original split deployment code#1182cameronlee314 merged 1 commit intoapache:masterfrom
cameronlee314 merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@sborya can you please take a look? |
prateekm
reviewed
Oct 10, 2019
samza-core/src/test/scala/org/apache/samza/job/TestShellCommandBuilder.scala
Show resolved
Hide resolved
prateekm
reviewed
Oct 10, 2019
prateekm
reviewed
Oct 10, 2019
Contributor
Author
He is busy with oncall this week. If you think it is important to wait for a review from him, then I can wait. |
Contributor
|
@cameronlee314 If Boris is OK with the overall change (removing the code + docs) then that's fine, we can commit. |
srinipunuru
approved these changes
Oct 10, 2019
Contributor
srinipunuru
left a comment
srinipunuru
left a comment
There was a problem hiding this comment.
Samza SQL doesn't use this.
Contributor
Author
|
Thanks for confirming @srinipunuru. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going to add new code for new split deployment strategy soon, so removing the original unused split deployment code.