SAMZA-2377: Batch mode should be computed based on generated configs#1215
Merged
xinyuiscool merged 1 commit intoapache:masterfrom Nov 12, 2019
Merged
SAMZA-2377: Batch mode should be computed based on generated configs#1215xinyuiscool merged 1 commit intoapache:masterfrom
xinyuiscool merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@mynameborat : pls help take a look. |
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the batch mode in job planner is computed based on the userconfig. This should be changed after the Samza InputDescriptor change. We should compute that based on the generated configs now.
Also add the logic to remove host affinity config for batch mode.