SAMZA-2418: Integration tests are failing and do not properly pass params to zopkio#1235
Merged
cameronlee314 merged 1 commit intoapache:masterfrom Dec 16, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom:
./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests --nopasswordfails and does not respect the--nopasswordparameter. Some of the documentation for testing does not have the correct commands for executing tests (i.e. missingyarn-integration-testsorstandalone-integration-testsargument)Cause:
yarn-integration-testsorstandalone-integration-testsargument was added by SAMZA-1748: Standalone failure tests. #554, but it looks like the argument parsing was not correctly updated to find the zopkio parameters. Also, not all of the test documentation was updated in that change.Fix:
"${*:3}"to"${@:3}"since@seems to be the cleaner in general (https://unix.stackexchange.com/questions/41571/what-is-the-difference-between-and); although I think*still worked in this case.Tests:
./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests --nopasswordand./bin/integration-tests.sh standalone-integration-tests --nopasswordboth succeed and do not ask for a password../bin/integration-tests.sh /tmp/samza-tests yarn-integration-testsgot to the stage where zopkio asked for a password.