SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase#1269
Merged
Merged
Conversation
…g the execution planning of the SQL statement.
Contributor
Author
|
@weiqingy Can you please take a look at this PR? |
Contributor
|
@santhoshvenkat1988 Couple of things that you could look at in future
|
Contributor
Author
|
Thanks for the review @srinipunuru
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: Incompatible types between UDF and schema is a irrecoverable error and it would kill the SamzaSQL job. Argument type validations in SamzaSQL UDF happens at runtime after the containers are launched. This causes operational inconvenience since these UDF type-errors causes a sql-job to fail at runtime.
Changes: This patch adds UDF validations to execution planning phase of SQL application. Operand checker in SamzaSQL is extended to house the udf argument type validation. This will ensure that the deployment of error-prone Samza SQL UDF will fail.
API changes: None
Upgrade/usage instructions: None