[Test fix]: Increasing heap allocation for test executor for samza-core tests after Gradle 5 upgrade#1307
Merged
Conversation
…re tests after Gradle 5 upgrade
Sanil15
approved these changes
Mar 9, 2020
mynameborat
approved these changes
Mar 9, 2020
shanthoosh
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom:
./gradlew builddoes not consistently succeed. Observed failures include tests reported as failing and/or running out of memory.Cause: Recently, we upgraded to Gradle 5. Gradle 5 lowered some memory allocation defaults (https://docs.gradle.org/5.0/userguide/upgrading_version_4.html#rel5.0:default_memory_settings), and it looks like the lower memory isn't sufficient for some tests.
Changes: Increase the memory for running tests for samza-core, which seems to be the impacted module.
Tests: Ran
./gradlew build