SAMZA-2486: Update TestFileReaderSystemAdmin to use test resource files#1315
Merged
lhaiesp merged 4 commits intoapache:masterfrom Mar 16, 2020
kw2542:master
Merged
SAMZA-2486: Update TestFileReaderSystemAdmin to use test resource files#1315lhaiesp merged 4 commits intoapache:masterfrom kw2542:master
lhaiesp merged 4 commits intoapache:masterfrom
kw2542:master
Conversation
Symptom: samza-core:test are randomly failing. Cause: TestFileReaderSystemAdmin and TestFileReaderSystemConsumer are creating and deleting the same set of files, when runnig in parallel, FileNotFoundException could happen depending on the timing. Changes: 1. Update TestFileReaderSystemAdmin to use test resource files. 2. Update assert conditions as we removed tailing spaces and newlines in the files. 3. Keep TestFileReaderSystemConsumer as it is because it is also appending data to test files, thus cannot share to use the same test resource file. Tests: ./gradlew test API Changes: None Upgrade Instructions: None Usage Instructions: None
Sanil15
approved these changes
Mar 16, 2020
Contributor
Sanil15
left a comment
Sanil15
left a comment
There was a problem hiding this comment.
Thanks for the patch, LGTM!
lhaiesp
approved these changes
Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom:
samza-core:test are randomly failing.
Cause:
TestFileReaderSystemAdmin and TestFileReaderSystemConsumer are creating and deleting the same set of files, when runnig in parallel, FileNotFoundException could happen depending on the timing.
Changes:
Tests:
./gradlew test
API Changes:
None
Upgrade Instructions:
None
Usage Instructions:
None