SAMZA-2514: Refactor codes to make runWithClassLoader method more generic#1349
Merged
Conversation
Signed-off-by: Alan Zhang <shuai.xyz@gmail.com>
cameronlee314
approved these changes
Apr 24, 2020
Signed-off-by: Alan Zhang <shuai.xyz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Currently, we define the
runWithClassLoadermethod inClusterBasedJobCoordinatorto support split deployment. However, the job container needs a similarrunWithClassLoadermethod to support split deployment. So we'd better make therunWithClassLoadermethod more generic, thenLocalContainerRunnercan just use it.Changes
Add new util class
SplitDeploymentUtilto define genericrunWithClassLoadermethod.Tests
API Changes
None
Upgrade Instructions
None
Usage Instructions
None