SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory#1369
Merged
mynameborat merged 11 commits intoapache:masterfrom Jun 11, 2020
Merged
SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory#1369mynameborat merged 11 commits intoapache:masterfrom
mynameborat merged 11 commits intoapache:masterfrom
Conversation
DiagnosticsUtil#buildDiagnosticsManager currently hard codes the creation of MetricsSnapshotReporter. This patch fixes this and creates the MetricsReporter using the factory defined in configs.
Contributor
Author
|
Please note: |
Contributor
|
lgtm. |
Contributor
|
Perhaps adding a test in TestDiagnosticsManager would be prudent? |
Contributor
Author
This patch doesn't change the DiagnoticsManager (hence nothing to change in TestDiagnosticsManager ??). Instead, I added a test to verify that the reporter created (using |
added 2 commits
June 1, 2020 10:20
Contributor
Author
|
Based on comments received on #1368. This patch removes exposing the producer in |
added 2 commits
June 9, 2020 16:45
rmatharu-zz
reviewed
Jun 10, 2020
added 5 commits
June 10, 2020 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiagnosticsUtil#buildDiagnosticsManager currently hard codes
the creation of MetricsSnapshotReporter.
This patch fixes this and creates the MetricsReporter
using the factory defined in configs.
Edit (06/01): This patch also changes
DiagnosticsUtil#buildDiagnosticsManagerto use two separate producers for the MetricsSnapshortReporter andDiagnotsticsManager.