Closed
Conversation
shanthoosh
force-pushed
the
fix-test-jmx-reporter
branch
from
26a5bfd to
09239d1
Compare
Contributor
Author
prateekm
requested changes
Apr 25, 2017
Contributor
prateekm
left a comment
prateekm
left a comment
There was a problem hiding this comment.
Will be good to add another assert to the test to make sure metrics are registered from the listener. Otherwise LGTM, thanks.
shanthoosh
force-pushed
the
fix-test-jmx-reporter
branch
from
09239d1 to
f27fda5
Compare
Replace spawning and connecting to JMX Server with mocking.
shanthoosh
force-pushed
the
fix-test-jmx-reporter
branch
from
f27fda5 to
25abff9
Compare
Contributor
Author
|
Added additional asserts to test metrics reporting through listener. Thanks. |
prateekm
approved these changes
Apr 25, 2017
| registry.newCounter(metricGroup, metricName) | ||
|
|
||
| assertTrue(stateViaJMX > 0) | ||
| assertEquals(1, registry.listeners.size) |
Contributor
There was a problem hiding this comment.
Not necessary, this is registry internal state.
Contributor
|
lgtm! Thanks for fixing this 👍 |
navina
approved these changes
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.