make MonitorPartition thread a daemon#1410
Merged
sborya merged 1 commit intoapache:masterfrom Aug 7, 2020
Merged
Conversation
lhaiesp
approved these changes
Aug 7, 2020
Contributor
|
Thanks for the fix! |
Contributor
Author
Sure. Will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom: sometime when application is shutting down, the MonitorPartion thread will prevent it from shutting down completely.
Cause: The reason is that this thread is not a daemon thread, so if it hangs (because of other parts are shutting down), the application will wait (indefinitely) until it completes the shutdown.
Changes: mark the thread a daemon thread.