SAMZA-2589: Consolidate Beam and High/Low Samza Apps launch workflow#1428
Merged
mynameborat merged 3 commits intoapache:masterfrom Sep 11, 2020
Merged
SAMZA-2589: Consolidate Beam and High/Low Samza Apps launch workflow#1428mynameborat merged 3 commits intoapache:masterfrom
mynameborat merged 3 commits intoapache:masterfrom
Conversation
Issues: app.main.class is only set for Beam apps which causes different workflow on AM when launching a job. Changes: 1. Introduce DefaultApplicationMain to capture launch workflow for High/Low level jobs so on AM, all jobs are launched in the same way: ClusterBasedJobCoordinatorRunner#main -> app.main.class -> JobCoordinatorLaunchUtil 2. Update ApplicationConfig#getAppMainClass to default to DefaultApplicationMain Tests: 1. Unit Tests 2. Deployed hello samza job successfully with the change following instructions on http://samza.apache.org/startup/hello-samza/latest/ API Changes: None Upgrade Instructions: None Usage Instructions: None
mynameborat
reviewed
Sep 10, 2020
Contributor
mynameborat
left a comment
mynameborat
left a comment
There was a problem hiding this comment.
Thank you! Mostly questions, looks good to me otherwise
samza-core/src/main/java/org/apache/samza/clustermanager/DefaultApplicationMain.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/config/ApplicationConfig.java
Outdated
Show resolved
Hide resolved
mynameborat
approved these changes
Sep 11, 2020
MabelYC
pushed a commit
to MabelYC/samza
that referenced
this pull request
Sep 14, 2020
…pache#1428) Issues: app.main.class is only set for Beam apps which causes different workflow on AM when launching a job. Changes: 1. Introduce DefaultApplicationMain to capture launch workflow for High/Low level jobs so on AM, all jobs are launched in the same way: ClusterBasedJobCoordinatorRunner#main -> app.main.class -> JobCoordinatorLaunchUtil 2. Update ApplicationConfig#getAppMainClass to default to DefaultApplicationMain Tests: 1. Unit Tests 2. Deployed hello samza job successfully with the change following instructions on http://samza.apache.org/startup/hello-samza/latest/ API Changes: None Upgrade Instructions: None Usage Instructions: None
lakshmi-manasa-g
pushed a commit
to lakshmi-manasa-g/samza
that referenced
this pull request
Feb 9, 2021
…pache#1428) Issues: app.main.class is only set for Beam apps which causes different workflow on AM when launching a job. Changes: 1. Introduce DefaultApplicationMain to capture launch workflow for High/Low level jobs so on AM, all jobs are launched in the same way: ClusterBasedJobCoordinatorRunner#main -> app.main.class -> JobCoordinatorLaunchUtil 2. Update ApplicationConfig#getAppMainClass to default to DefaultApplicationMain Tests: 1. Unit Tests 2. Deployed hello samza job successfully with the change following instructions on http://samza.apache.org/startup/hello-samza/latest/ API Changes: None Upgrade Instructions: None Usage Instructions: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: app.main.class is only set for Beam apps which causes different workflow on AM when launching a job.
Changes:
Tests:
API Changes: None
Upgrade Instructions: None
Usage Instructions: None