SAMZA-2574 : improve flexibility of SystemFactory interface#1430
Merged
sborya merged 3 commits intoapache:masterfrom Sep 22, 2020
Merged
SAMZA-2574 : improve flexibility of SystemFactory interface#1430sborya merged 3 commits intoapache:masterfrom
sborya merged 3 commits intoapache:masterfrom
Conversation
sborya
approved these changes
Sep 22, 2020
| * @return SystemAdmin of the system if it exists, otherwise null. | ||
| */ | ||
| public SystemAdmin getSystemAdmin(String systemName, String adminLabel) { | ||
| if (systemAdminMap.isEmpty() || (systemAdminMap.containsKey(systemName) && systemAdminMap.get(systemName).isStopped())) { |
Contributor
There was a problem hiding this comment.
no need for isEmpty() check.
sborya
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is second pr to supplement commit: 4d97a8d
Changes: Added addition label info to SystemAdmin to help user provide more information to SystemFactory.
API Changes: Added several new functions to help provide more parameter. Won't impact current users.
Upgrade Instructions: None
Usage Instructions: None