SAMZA-2613: API Changes to make Standby Container Allocation Rack Aware#1453
Merged
mynameborat merged 1 commit intoapache:masterfrom Dec 22, 2020
Merged
Conversation
mynameborat
approved these changes
Dec 22, 2020
Contributor
mynameborat
left a comment
There was a problem hiding this comment.
Reviewed these changes as part of #1446. Splitting into separate PR to get the API changes in first.
Looks good to me.
lakshmi-manasa-g
pushed a commit
to lakshmi-manasa-g/samza
that referenced
this pull request
Feb 9, 2021
) Feature: The aim of this feature is to make all standby container requests rack aware such that all active containers and their corresponding standby containers are always on different racks. This helps with decreased downtime of applications during rack failures. One of the requirements of this feature is that the value of job.standbytasks.replication.factor is at max 2 for the rack awareness functionality to be honored. Changes: Added a new interface called FaultDomainManager which implements the YarnFaultDomainManager class for Yarn. This class takes care of the retrieval of node to rack information from Yarn. Also defined what FaultDomain and FaultDomainType means. Added config to enable making fault domain aware requests. Added metrics to track fault domain aware requests. API Changes: Added a new FaultDomainManager interface.
tranjith
pushed a commit
to tranjith/samza
that referenced
this pull request
Mar 23, 2021
) Feature: The aim of this feature is to make all standby container requests rack aware such that all active containers and their corresponding standby containers are always on different racks. This helps with decreased downtime of applications during rack failures. One of the requirements of this feature is that the value of job.standbytasks.replication.factor is at max 2 for the rack awareness functionality to be honored. Changes: Added a new interface called FaultDomainManager which implements the YarnFaultDomainManager class for Yarn. This class takes care of the retrieval of node to rack information from Yarn. Also defined what FaultDomain and FaultDomainType means. Added config to enable making fault domain aware requests. Added metrics to track fault domain aware requests. API Changes: Added a new FaultDomainManager interface.
shekhars-li
pushed a commit
to shekhars-li/samza
that referenced
this pull request
May 28, 2021
) Feature: The aim of this feature is to make all standby container requests rack aware such that all active containers and their corresponding standby containers are always on different racks. This helps with decreased downtime of applications during rack failures. One of the requirements of this feature is that the value of job.standbytasks.replication.factor is at max 2 for the rack awareness functionality to be honored. Changes: Added a new interface called FaultDomainManager which implements the YarnFaultDomainManager class for Yarn. This class takes care of the retrieval of node to rack information from Yarn. Also defined what FaultDomain and FaultDomainType means. Added config to enable making fault domain aware requests. Added metrics to track fault domain aware requests. API Changes: Added a new FaultDomainManager interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: The aim of this feature is to make all standby container requests rack aware such that all active containers and their corresponding standby containers are always on different racks. This helps with decreased downtime of applications during rack failures. One of the requirements of this feature is that the value of
job.standbytasks.replication.factoris at max 2 for the rack awareness functionality to be honored.Changes:
FaultDomainManagerwhich implements theYarnFaultDomainManagerclass for Yarn. This class takes care of the retrieval of node to rack information from Yarn.FaultDomainandFaultDomainTypemeans.API Changes: Added a new FaultDomainManager interface.
Tests: Unit Testing and tested with a running job.
Upgrade instructions: TBD
Usage Instructions: For a job with host affinity and standby containers, set the config
cluster-manager.fault-domain-aware.standby.enabledto true to enable this feature.