SAMZA-2563: Fix double counting of InMemoryKeyValueStore deletion#1458
Merged
mynameborat merged 1 commit intoapache:masterfrom Feb 4, 2021
Merged
SAMZA-2563: Fix double counting of InMemoryKeyValueStore deletion#1458mynameborat merged 1 commit intoapache:masterfrom
mynameborat merged 1 commit intoapache:masterfrom
Conversation
mynameborat
approved these changes
Feb 3, 2021
tranjith
pushed a commit
to tranjith/samza
that referenced
this pull request
Mar 23, 2021
…ache#1458) Symptom: Calling InMemoryKeyValueStore.delete will double count the deletes in metrics. Cause: InMemoryKeyValueStore.delete is implemented by calling InMemoryKeyValueStore.put with a null value. InMemoryKeyValueStore.delete explicitly increments the delete metric. InMemoryKeyValueStore.put also explicitly increments the delete metric when passed a null value. Changes: Remove incrementing the delete metric in InMemoryKeyValueStore.delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom: Calling InMemoryKeyValueStore.delete will double count the deletes in metrics.
Cause: InMemoryKeyValueStore.delete is implemented by calling InMemoryKeyValueStore.put with a null value. InMemoryKeyValueStore.delete explicitly increments the delete metric. InMemoryKeyValueStore.put also explicitly increments the delete metric when passed a null value.
Changes: Remove incrementing the delete metric in InMemoryKeyValueStore.delete
Test: unit tests