SAMZA-2618: Add per-container metric for memory-utilization#1459
Merged
mynameborat merged 1 commit intoapache:masterfrom Feb 3, 2021
Merged
SAMZA-2618: Add per-container metric for memory-utilization#1459mynameborat merged 1 commit intoapache:masterfrom
mynameborat merged 1 commit intoapache:masterfrom
Conversation
mynameborat
reviewed
Feb 3, 2021
Contributor
mynameborat
left a comment
mynameborat
left a comment
There was a problem hiding this comment.
Thanks for contributing to samza :)
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
Outdated
Show resolved
Hide resolved
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
Outdated
Show resolved
Hide resolved
Contributor
|
@ZitingShen With travis being slow, would you mind hooking up your repository to travis-ci.com and adding the CI build report to the PR. I can then merge it. |
Contributor
Author
@mynameborat It seems the CI build already passed https://travis-ci.org/github/apache/samza/builds/757470170 |
mynameborat
approved these changes
Feb 3, 2021
tranjith
pushed a commit
to tranjith/samza
that referenced
this pull request
Mar 23, 2021
) Feature: Add a metric to measure the fraction of physical memory used out of the total memory of the container. During autosizing, the container-count and size can change as traffic changes, so only monitoring the phsical-memory-mb does not provide enough information for alerting. We need a fraction or % metric to allow for easy monitoring and alerting Changes: Add a metric to measure the fraction of physical memory used out of the total memory of the container.
shekhars-li
pushed a commit
to shekhars-li/samza
that referenced
this pull request
May 28, 2021
) Feature: Add a metric to measure the fraction of physical memory used out of the total memory of the container. During autosizing, the container-count and size can change as traffic changes, so only monitoring the phsical-memory-mb does not provide enough information for alerting. We need a fraction or % metric to allow for easy monitoring and alerting Changes: Add a metric to measure the fraction of physical memory used out of the total memory of the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Add a metric to measure the fraction of physical memory used out of the total memory of the container. During autosizing, the container-count and size can change as traffic changes, so only monitoring the phsical-memory-mb does not provide enough information for alerting. We need a fraction or % metric to allow for easy monitoring and alerting
Changes: Add a metric to measure the fraction of physical memory used out of the total memory of the container.
Tests: unit tests; end-to-end test with samza-hello-samza and inspect the metrics MBean with JMX Reporter
