Skip to content

SAMZA-2640: Fixing errors in WindowType examples in High Level API doc#1482

Merged
Sanil15 merged 1 commit intoapache:masterfrom
ajothomas:WindowTypeDocumentationFix
Mar 26, 2021
Merged

SAMZA-2640: Fixing errors in WindowType examples in High Level API doc#1482
Sanil15 merged 1 commit intoapache:masterfrom
ajothomas:WindowTypeDocumentationFix

Conversation

@ajothomas
Copy link
Contributor

@ajothomas ajothomas commented Mar 25, 2021

Issue:
The Window Types section in the High Level API documentation has a few mistakes:

  1. Missing variable name for a Tumbling window example
  2. Incorrect example for Session windows (seems like a copy paste issue from Tumbling window example)

Changes:

  1. Added missing variable name for the Tumbling window example
  2. Incorrect code was removed from the Session window section and a new example was added in its place.

Tests
NA. Since this is only a doc fix.

Copy link
Contributor

@Sanil15 Sanil15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Please follow guidelines here for naming, description of PR: https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+PR+Title+And+Description+Guidelines

@ajothomas ajothomas changed the title High Level API documentation Fix DOCS: Fixing errors in WindowType examples in High Level API doc Mar 25, 2021
@ajothomas ajothomas changed the title DOCS: Fixing errors in WindowType examples in High Level API doc SAMZA-2640: Fixing errors in WindowType examples in High Level API doc Mar 25, 2021
@Sanil15 Sanil15 merged commit 29deb42 into apache:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants