[Tests] Add longer delay time to mitigate flaky test in TestAsyncFlatMap#1561
Merged
cameronlee314 merged 1 commit intoapache:masterfrom Nov 18, 2021
Merged
Conversation
mynameborat
approved these changes
Nov 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
TestAsyncFlatMap.testProcessingFutureCompletesAfterTaskTimeoutfails transiently. It looks like the task timeout gets triggered (which would set the error to the expected error for the test), but occasionally, before theRunLoopexits, the actual processing task completes, and then the final error is overridden to beCallback complete was invoked after completion...(which is not the expected error). The difference between the timeout and the actual processing time is 100ms, so if theRunLoopdoesn't exit within 100ms, then this test will fail.Changes: Increase the delay time in the test so that the
RunLoophas more time to exit before the actual processing task completes.Tests:
TestAsyncFlatMap.testProcessingFutureCompletesAfterTaskTimeoutpassesAPI changes: N/A