SAMZA-2711: Fix flaky TestZkLocalApplicationRunner#1563
Merged
cameronlee314 merged 1 commit intoapache:masterfrom Dec 6, 2021
Merged
SAMZA-2711: Fix flaky TestZkLocalApplicationRunner#1563cameronlee314 merged 1 commit intoapache:masterfrom
cameronlee314 merged 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
TestZkLocalApplicationRunner.shouldStopNewProcessorsJoiningGroupWhenNumContainersIsGreaterThanNumTasks asserts
A) JobModel generated before and after the addition of appRunner2 should be equal.
B) Second stream application(appRunner2) should not join the group and process any message.
Assertion A is good, but the test can not guarantee Assertion B.
The reason is that the test kill appRunner1 then kill appRunner2, but after appRunner1 got killed and before appRunner2 gets killed, ZkJobCoordinator could generate a new JobModel with appRunner 2
That leads to appRunner2 status change from New->Running->SuccessfulFinish
instead of New->UnsuccessfulFinish, which result in the test failure
Changes:
kill appRunner2 and do assertion before kill appRunner1
Tests: ./gradlew build
API changes: N/A