Skip to content

Not ready for review: Attempt to fix up rat #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bringhurst wants to merge 1 commit into from
Closed

Not ready for review: Attempt to fix up rat #1619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 18 additions & 34 deletions gradle/rat.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
* under the License.
*/

import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.Task
import org.gradle.api.internal.project.IsolatedAntBuilder

apply plugin: RatPlugin
Expand All @@ -28,36 +25,19 @@ class RatTask extends DefaultTask {
@Input
List<String> excludes

def reportPath = 'build/rat'
def stylesheet = 'gradle/resources/rat-output-to-html.xsl'
def xmlReport = reportPath + '/rat-report.xml'
def htmlReport = reportPath + '/rat-report.html'
def textReport = reportPath + '/rat-report.txt'

def generateTextReport(File reportDir) {
def antBuilder = services.get(IsolatedAntBuilder)
def ratClasspath = project.configurations.rat
antBuilder.withClasspath(ratClasspath).execute {
ant.taskdef(resource: 'org/apache/rat/anttasks/antlib.xml')
ant.report(format: 'plain', reportFile: textReport) {
fileset(dir: ".") {
patternset {
excludes.each {
exclude(name: it)
}
}
}
}
}
}
def reportDir = project.file('build/rat')
def stylesheet = project.file('gradle/resources/rat-output-to-html.xsl').getAbsolutePath()
def xmlReport = new File(reportDir, 'rat-report.xml')
def htmlReport = new File(reportDir, 'rat-report.html')

def generateXmlReport(File reportDir) {
def antBuilder = services.get(IsolatedAntBuilder)
def ratClasspath = project.configurations.rat
def projectPath = project.getRootDir().getAbsolutePath()
antBuilder.withClasspath(ratClasspath).execute {
ant.taskdef(resource: 'org/apache/rat/anttasks/antlib.xml')
ant.report(format: 'xml', reportFile: xmlReport) {
fileset(dir: ".") {
fileset(dir: projectPath) {
patternset {
excludes.each {
exclude(name: it)
Expand Down Expand Up @@ -98,26 +78,30 @@ class RatTask extends DefaultTask {

@TaskAction
def rat() {
File reportDir = new File(reportPath)
if (!reportDir.exists()) {
reportDir.mkdirs()
}
generateXmlReport(reportDir)
generateHtmlReport()
generateTextReport()
printUnknownFiles()
def origEncoding = System.getProperty("file.encoding")
try {
System.setProperty("file.encoding", "UTF-8") //affects the output of the ant rat task
generateXmlReport(reportDir)
printUnknownFiles()
generateHtmlReport()
} finally {
System.setProperty("file.encoding", origEncoding)
}
}
}

class RatPlugin implements Plugin<Project> {
void apply(Project project) {
configureDependencies(project)
project.plugins.apply(JavaBasePlugin);
project.plugins.apply(JavaPlugin);
Task ratTask = project.task("rat",
type: RatTask,
group: 'Build',
description: 'Runs Apache Rat checks.')
project.tasks[JavaBasePlugin.CHECK_TASK_NAME].dependsOn ratTask
project.tasks[JavaPlugin.TEST_TASK_NAME].dependsOn ratTask
}

void configureDependencies(final Project project) {
Expand All @@ -128,7 +112,7 @@ class RatPlugin implements Plugin<Project> {
mavenCentral()
}
project.dependencies {
rat 'org.apache.rat:apache-rat-tasks:0.8'
rat 'org.apache.rat:apache-rat-tasks:0.12'
}
}
}