SAMZA-1495: Set intermediate streams as higher priority by default #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @vjagadish1989 @xinyuiscool for review |
vjagadish1989
approved these changes
Nov 15, 2017
| if (isIntermediate()) { | ||
| config.put(String.format(StreamConfig.IS_INTERMEDIATE_FOR_STREAM_ID(), spec.getId()), "true"); | ||
| config.put(String.format(StreamConfig.CONSUMER_OFFSET_DEFAULT_FOR_STREAM_ID(), spec.getId()), "oldest"); | ||
| config.put(String.format(StreamConfig.PRIORITY_FOR_STREAM_ID(), spec.getId()), "1"); |
Contributor
There was a problem hiding this comment.
If a user already has prioritized streams, would this put the intermediate stream at the same priority as their input?. Alternately, You could set to INT_MAX here to avoid conflicting with configured priorities?
Contributor
Author
There was a problem hiding this comment.
Makes sense, will change to INT_MAX
| if (isIntermediate()) { | ||
| config.put(String.format(StreamConfig.IS_INTERMEDIATE_FOR_STREAM_ID(), spec.getId()), "true"); | ||
| config.put(String.format(StreamConfig.CONSUMER_OFFSET_DEFAULT_FOR_STREAM_ID(), spec.getId()), "oldest"); | ||
| config.put(String.format(StreamConfig.PRIORITY_FOR_STREAM_ID(), spec.getId()), "1"); |
Contributor
There was a problem hiding this comment.
Consider adding an assert to https://github.com/apache/samza/blob/master/samza-core/src/test/java/org/apache/samza/execution/TestStreamEdge.java as well if possible?
vjagadish1989
pushed a commit
to vjagadish1989/samza
that referenced
this pull request
Dec 5, 2017
Most changes in StreamConfig are formatting fixes. Author: Prateek Maheshwari <pmaheshw@linkedin.com> Reviewers: Jagadish Venkatraman <vjagadish1989@gmail.com> Closes apache#358 from prateekm/intermediate-stream-priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes in StreamConfig are formatting fixes.