Skip to content

SAMZA-2163: Add try-catch to get the version in MetricsSnapshotReporterFactory #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xinyuiscool merged 1 commit into from
Apr 11, 2019
Merged

SAMZA-2163: Add try-catch to get the version in MetricsSnapshotReporterFactory #992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions ...ore/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,17 @@ class MetricsSnapshotReporterFactory extends MetricsReporterFactory with Logging
val jobId = config
.getJobId

val taskClass = Option(new ApplicationConfig(config).getAppClass())
.getOrElse(config.getTaskClass.getOrElse(throw new SamzaException("No task or app class defined for config.")))

val version = Option(Class.forName(taskClass).getPackage.getImplementationVersion)
.getOrElse({
warn("Unable to find implementation version in jar's meta info. Defaulting to 0.0.1.")
"0.0.1"
})
val version =
try {
val taskClass = Option(new ApplicationConfig(config).getAppClass())
.orElse(config.getTaskClass).get
Option(Class.forName(taskClass).getPackage.getImplementationVersion).get
} catch {
case e: Exception => {
warn("Unable to find implementation version in jar's meta info. Defaulting to 0.0.1.")
Copy link
Copy Markdown
Contributor

@lhaiesp lhaiesp Apr 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we log the exception? And we should document why we need to catch exception here (anonymous class..), so that we don't lose context in the codes.

Copy link
Copy Markdown
Contributor Author

@xinyuiscool xinyuiscool Apr 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the warning line should be good here, since mostly likely it will be NoSuchElementException if no class is found or no version is found. Currently we are mostly getting 0.0.1 right now.

"0.0.1"
}
}

val samzaVersion = Option(classOf[MetricsSnapshotReporterFactory].getPackage.getImplementationVersion)
.getOrElse({
Expand Down