SAMZA-2166: [Scala cleanup] Convert StorageConfig.scala to Java #996
Merged
Conversation
mynameborat
approved these changes
Apr 30, 2019
shanthoosh
reviewed
May 7, 2019
shanthoosh
approved these changes
May 8, 2019
prateekm
pushed a commit
to prateekm/samza
that referenced
this pull request
May 12, 2019
…che#996) * SAMZA-2166: [Scala cleanup] Convert StorageConfig.scala to Java * rename JavaStorageConfig to StorageConfig * consolidate usage of key and msg serde access in ContainerStorageManager * improve javadocs for optional instead of null; clean up StorageConfig constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might be easier to view this PR by looking at individual commits. The commit a34e320 contains the change to just remove
StorageConfig.scalaand replace withJavaStorageConfig.java. The next commit 501ae36 does a rename fromJavaStorageConfig.javatoStorageConfig.java, sinceStorageConfig.scalawas removed.Note: This also seems to fix a bug in
BaseKeyValueStorageEngineFactorywhich involved reading the access log sample ratio config. Previously, the config being passed in toBaseKeyValueStorageEngineFactorywas stripped of thestores.<store name>.prefix, but it was implicitly converted into aStorageConfig, so whengetAccessLogSamplingRatiowas called, it seems like it would never actually find the fullstores.<store name>.accesslog.sampling.ratio. This meant it always fell back to the default value.