Closed
Conversation
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Contributor
Author
|
@coheigea Hi, I hope you are not on holidays now ;-) |
Contributor
|
I was last week but back now :-) IMO these changes are too intrusive and are not necessary. Can we restrict adding final to member variables? |
Member
|
I agree with Colm. |
Contributor
Author
Then it is easier for me just to revert all these changes in the #101 . The project doesn't have any rules, so it is just your opinions and I have to respect them. I already spent too much time with this project which was basically just reducing differences between branches. This PR was to set the same rule everywhere, yet without checkstyle which I would recommend too, BUT ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the review of #101 I asked Eclipse IDE to add the
finalkeyword to all local variables and all fields where it was possible.