[Improve][Connector-V2][My Hours]Add http method enum && Improve My Hours connector option rule#3390
Merged
EricJoy2048 merged 8 commits intoapache:devfrom Nov 15, 2022
Merged
Conversation
EricJoy2048
reviewed
Nov 11, 2022
| .optional(MyHoursSourceConfig.METHOD) | ||
| .optional(MyHoursSourceConfig.HEADERS) | ||
| .optional(MyHoursSourceConfig.PARAMS) | ||
| .conditional(Condition.of(HttpConfig.METHOD, "post"), MyHoursSourceConfig.BODY) |
Member
There was a problem hiding this comment.
Please use enum type option.
Member
There was a problem hiding this comment.
+1, please use enum type option.
EricJoy2048
added
waiting for review
Waiting for code update
and removed
waiting for review
labels
TaoZex
changed the title
|
|
||
| package org.apache.seatunnel.connectors.seatunnel.http.config; | ||
|
|
||
| public enum Method { |
Member
There was a problem hiding this comment.
HttpRequestMethod is better.
| this.setMethod(method); | ||
| } else { | ||
| this.setMethod(HttpConfig.METHOD_DEFAULT_VALUE); | ||
| this.setMethod(Method.GET); |
Member
There was a problem hiding this comment.
HttpConfig.METHOD.defaultValue() is better.
Contributor
Author
There was a problem hiding this comment.
Thanks. I have fixed it.
Contributor
Author
|
@EricJoy2048 @Hisoka-X PTAL |
Hisoka-X
reviewed
Nov 14, 2022
| .stringType() | ||
| .defaultValue(METHOD_DEFAULT_VALUE) | ||
| public static final Option<HttpRequestMethod> METHOD = Options.key("method") | ||
| .objectType(HttpRequestMethod.class) |
Contributor
Author
There was a problem hiding this comment.
Thanks for your advice.I have fixed it.
Hisoka-X
approved these changes
Nov 14, 2022
EricJoy2048
approved these changes
Nov 15, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
1.Add http method enum
2.Improve My Hours connector option rule.
Check list
New License Guide