[Feature][Connector V2] Add GoogleSheets Sink by TaoZex · Pull Request #3848 · apache/seatunnel

TaoZex · 2023-01-02T11:42:25Z

Purpose of this pull request

improve pr : #3411

Check list

Code changed are covered with tests, or it does not need tests for reason:
If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to connector-v2
2. Update plugin-mapping.properties and add new connector information in it
3. Update the pom file of seatunnel-dist

TaoZex · 2023-01-02T11:47:44Z

I don't have permission to update this pr:#3411
So I created this pr to improve it. @EricJoy2048

CalvinKirs

Please provide UT or IT to verify this, you can set to disable, but we should have a test code that can be quickly and easily configured and then run.

TaoZex · 2023-01-03T05:32:19Z

Please provide UT or IT to verify this, you can set to disable, but we should have a test code that can be quickly and easily configured and then run.

Thanks for your advice. I will add e2e test code.

…ex/incubator-seatunnel into googlesheets_sink_connector

docs/en/connector-v2/sink/GoogleSheets.md

...main/java/org/apache/seatunnel/connectors/seatunnel/google/sheets/sink/SheetsSinkWriter.java

…ex/incubator-seatunnel into googlesheets_sink_connector

TaoZex · 2023-02-14T07:03:40Z

@EricJoy2048 I have resolved conflict. PTAL.

TyrantLucifer

Update release-note plugin_config seatunnel-dist

TyrantLucifer · 2023-02-27T14:49:33Z

docs/en/connector-v2/sink/GoogleSheets.md

+
+> GoogleSheets sink connector
+>
+  ## Description


remove blank

TyrantLucifer · 2023-02-27T14:51:24Z

...in/java/org/apache/seatunnel/connectors/seatunnel/google/sheets/config/SheetsParameters.java

+                        sourceCredentials.createScoped(
+                                Collections.singletonList(SheetsScopes.SPREADSHEETS));
+        HttpRequestInitializer requestInitializer = new HttpCredentialsAdapter(sourceCredentials);
+        NetHttpTransport httpTransport = null;


Suggested change

NetHttpTransport httpTransport = null;

NetHttpTransport httpTransport;

TyrantLucifer · 2023-02-27T14:52:36Z

...e/seatunnel/connectors/seatunnel/google/sheets/exception/GoogleSheetsConnectorErrorCode.java

+    }
+
+    @Override
+    public String getErrorMessage() {


TyrantLucifer · 2023-02-27T14:58:27Z

Offser the snapshot images of this connectors in different engines (flink spark zeta), not the snapshot images of seatunnel-examples, you need compile it and run test cases in integration test env.

hailin0 · 2023-05-19T06:52:26Z

waitting ci

hailin0 · 2023-05-22T04:05:52Z

LGTM

TyrantLucifer

Please offer test screenshots.

TyrantLucifer · 2023-05-22T04:16:11Z

...nnector-v2-e2e/connector-googlesheets-e2e/src/test/resources/fakesource_to_googlesheets.conf

+      fields {
+        name = "string"
+        address = "string"
+        age = "int"


test all data types

TyrantLucifer · 2023-07-27T03:54:27Z

Any process this pull request?

TaoZex added 2 commits January 2, 2023 19:38

[Feature][Connector V2] Add GoogleSheets Sink

b94d342

[Feature][Connector V2] fix doc

e4e5cc8

CalvinKirs requested changes Jan 3, 2023

View reviewed changes

TaoZex added 2 commits January 5, 2023 17:44

[Feature][Connector-V2][GoogleSheets]Add e2e test

1e98c1c

Merge branch 'dev' into googlesheets_sink_connector

c7565de

TaoZex requested a review from CalvinKirs January 5, 2023 09:49

TaoZex closed this Jan 5, 2023

TaoZex reopened this Jan 5, 2023

TaoZex added 2 commits January 5, 2023 21:15

[Feature][Connector-V2][GoogleSheets] change sink factory

9e5812b

Merge branch 'googlesheets_sink_connector' of https://github.com/TaoZ…

79dcb8e

…ex/incubator-seatunnel into googlesheets_sink_connector

TaoZex closed this Jan 5, 2023

TaoZex reopened this Jan 5, 2023

Merge branch 'dev' into googlesheets_sink_connector

18ee656

Zephyrcf mentioned this pull request Jan 16, 2023

[Feature][Statistics] Connector pr not yet merged #3960

Closed

3 tasks

EricJoy2048 reviewed Jan 31, 2023

View reviewed changes

docs/en/connector-v2/sink/GoogleSheets.md Outdated Show resolved Hide resolved

...main/java/org/apache/seatunnel/connectors/seatunnel/google/sheets/sink/SheetsSinkWriter.java Outdated Show resolved Hide resolved

TaoZex added 3 commits February 8, 2023 23:25

fix doc

09f8604

Merge branch 'apache:dev' into googlesheets_sink_connector

bd98579

Merge branch 'googlesheets_sink_connector' of https://github.com/TaoZ…

ffbfdbf

…ex/incubator-seatunnel into googlesheets_sink_connector

TaoZex requested review from EricJoy2048 and removed request for CalvinKirs February 10, 2023 05:56

TaoZex added 2 commits February 14, 2023 14:30

Merge branch 'dev' into googlesheets_sink_connector

69b2ae7

fix

23f4efd

TyrantLucifer requested changes Feb 27, 2023

View reviewed changes

Merge branch 'dev' into googlesheets_sink_connector

fb9e9cd

hailin0 approved these changes May 22, 2023

View reviewed changes

TyrantLucifer requested changes May 22, 2023

View reviewed changes

TaoZex closed this Jul 31, 2023

	NetHttpTransport httpTransport = null;
	NetHttpTransport httpTransport;

Conversation

TaoZex commented Jan 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this pull request

Check list

Uh oh!

TaoZex commented Jan 2, 2023

Uh oh!

CalvinKirs left a comment

Choose a reason for hiding this comment

Uh oh!

TaoZex commented Jan 3, 2023

Uh oh!

Uh oh!

Uh oh!

TaoZex commented Feb 14, 2023

Uh oh!

TyrantLucifer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TyrantLucifer Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

TyrantLucifer Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

TyrantLucifer Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

TyrantLucifer commented Feb 27, 2023

Uh oh!

hailin0 commented May 19, 2023

Uh oh!

hailin0 commented May 22, 2023

Uh oh!

TyrantLucifer left a comment

Choose a reason for hiding this comment

Uh oh!

TyrantLucifer May 22, 2023

Choose a reason for hiding this comment

Uh oh!

TyrantLucifer commented Jul 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TaoZex commented Jan 2, 2023 •

edited

Loading

TyrantLucifer left a comment •

edited

Loading