Skip to content

[Bug][Connector-v2][RedisSink]Fix failures caused by different cluster mode operations.#5300

Closed
lightzhao wants to merge 9 commits intoapache:devfrom
lightzhao:redis-cluster-operate
Closed

[Bug][Connector-v2][RedisSink]Fix failures caused by different cluster mode operations.#5300
lightzhao wants to merge 9 commits intoapache:devfrom
lightzhao:redis-cluster-operate

Conversation

@lightzhao
Copy link
Contributor

Purpose of this pull request

If the redis mode is a cluster type, it will fail when operating the expire method.
So different redis cluster types should declare and use corresponding objects.

Check list

Hisoka-X
Hisoka-X previously approved these changes Aug 24, 2023
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lightzhao , over all fine. @TyrantLucifer maybe you should take a look, please.

@Hisoka-X
Copy link
Member

The code style should be fixed.

@zhilinli123
Copy link
Contributor

hello @lightzhao Can you provide v2 connector documentation for this expressing thanks

Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expire feature has some problems, I think this feature #4975 should revert and redesign it. For expire key, we should only operation once not every time after set operation.

@TyrantLucifer
Copy link
Member

BTW, whether in cluster mode or standalone mode, all operations should be abstracted into upper level interfaces

@lightzhao
Copy link
Contributor Author

Expire feature has some problems, I think this feature #4975 should revert and redesign it. For expire key, we should only operation once not every time after set operation.

What does it mean to operate only once, and how to implement only one operation?

@lightzhao
Copy link
Contributor Author

BTW, whether in cluster mode or standalone mode, all operations should be abstracted into upper level interfaces

This looks good, abstract class + interface can implement different client operations.

@lightzhao
Copy link
Contributor Author

hello @lightzhao Can you provide v2 connector documentation for this expressing thanks

ok, i try it.

@lightzhao
Copy link
Contributor Author

I will redesign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants