Skip to content

[Fix][Command] On windows, canot stop cluster with stop-seatunnel-cluster.cmd#8939

Closed
FrommyMind wants to merge 19 commits intoapache:devfrom
FrommyMind:fix-8930
Closed

[Fix][Command] On windows, canot stop cluster with stop-seatunnel-cluster.cmd#8939
FrommyMind wants to merge 19 commits intoapache:devfrom
FrommyMind:fix-8930

Conversation

@FrommyMind
Copy link
Contributor

Purpose of this pull request

Fix #8930

Does this PR introduce any user-facing change?

No

How was this patch tested?

I tested on my own windows pc.

Check list

@github-actions github-actions bot added the core SeaTunnel core module label Mar 8, 2025
@Hisoka-X
Copy link
Member

Could you help verify it? @hawk9821

@hawk9821
Copy link
Contributor

hawk9821 commented Mar 11, 2025

image

image

@FrommyMind
Copy link
Contributor Author

image

image

If this command not installed in os by default, there will be a problem.
Anyone have new idea about this?

@FrommyMind
Copy link
Contributor Author

How about give the user guide about how to install wmic command on their pc?

tasklist command do not have information about the java process details.
image

Or, write a pid file when start cluster?

Copy link
Contributor

@hawk9821 hawk9821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to describe wmic in the doc

@github-actions github-actions bot added the CI&CD label Mar 19, 2025
@github-actions github-actions bot removed the CI&CD label Mar 20, 2025
@hailin0 hailin0 requested a review from Copilot March 31, 2025 05:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates documentation examples by changing the deployment and quick start links from .md to .mdx files, ensuring that the examples point to the new documentation format.

  • Updated reference links in example blocks across multiple connector documentation files
  • Adjusted markdown syntax from “->” to “+>” to reflect the new example style

Reviewed Changes

Copilot reviewed 38 out of 40 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/en/connector-v2/source/Sls.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/source/Kafka.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/source/Clickhouse.md Updated deployment link to use .mdx extension
docs/en/connector-v2/sink/Vertica.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/Snowflake.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/Sls.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/S3File.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/Pulsar.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/PostgreSql.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/Oracle.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/OceanBase.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/Mysql.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/Kingbase.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/Kafka.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/DB2.md Updated deployment and quick start links to use .mdx extension
docs/en/connector-v2/sink/OssFile.md Updated deployment link to use .mdx extension
docs/en/connector-v2/sink/Clickhouse.md Updated deployment link to use .mdx extension
Files not reviewed (2)
  • docs/en/start-v2/kubernetes/kubernetes.mdx: Language not supported
  • docs/en/start-v2/locally/deployment.mdx: Language not supported

@hailin0
Copy link
Member

hailin0 commented Apr 8, 2025

Please resolve the conflict

image

# Conflicts:
#	docs/en/start-v2/locally/deployment.mdx
@github-actions
Copy link

github-actions bot commented Aug 8, 2025

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Aug 8, 2025
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core SeaTunnel core module document stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Command] On windows, canot stop cluster with stop-seatunnel-cluster.cmd

4 participants

Comments