Skip to content

verify-release-candidate.sh doesn't skip tests for disabled features #412

@petern48

Description

@petern48

e.g. If I don't set MATURIN_PEP517_ARGS="--features s2geography", I'd expect the geography tests to be skipped instead of just fail.

sedonadb/tests/test_sjoin.py:141: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../venv/lib/python3.13/site-packages/sedonadb/testing.py:344: in execute_and_collect
    return self.con.sql(query).to_arrow_table()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../venv/lib/python3.13/site-packages/sedonadb/dataframe.py:257: in to_arrow_table
    return pa.table(self)
           ^^^^^^^^^^^^^^
pyarrow/table.pxi:6228: in pyarrow.lib.table
    ???
pyarrow/ipc.pxi:848: in pyarrow.lib.RecordBatchReader.read_all
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   ???
E   pyarrow.lib.ArrowInvalid: External error: This feature is not implemented: Implementation for st_distance([WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" })), WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" }))]) was not registered

pyarrow/error.pxi:92: ArrowInvalid
=================================================== short test summary info ====================================================
FAILED sedonadb/tests/test_sjoin.py::test_spatial_join_geography[ST_Intersects(sjoin_geog1.geog, sjoin_geog2.geog)-INNER JOIN] - pyarrow.lib.ArrowInvalid: External error: This feature is not implemented: Implementation for st_intersects([WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" })), WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" }))]) was not registered
FAILED sedonadb/tests/test_sjoin.py::test_spatial_join_geography[ST_Intersects(sjoin_geog1.geog, sjoin_geog2.geog)-LEFT OUTER JOIN] - pyarrow.lib.ArrowInvalid: External error: This feature is not implemented: Implementation for st_intersects([WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" })), WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" }))]) was not registered
FAILED sedonadb/tests/test_sjoin.py::test_spatial_join_geography[ST_Intersects(sjoin_geog1.geog, sjoin_geog2.geog)-RIGHT OUTER JOIN] - pyarrow.lib.ArrowInvalid: External error: This feature is not implemented: Implementation for st_intersects([WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" })), WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" }))]) was not registered
FAILED sedonadb/tests/test_sjoin.py::test_spatial_join_geography[ST_Distance(sjoin_geog1.geog, sjoin_geog2.geog) < 100000-INNER JOIN] - pyarrow.lib.ArrowInvalid: External error: This feature is not implemented: Implementation for st_distance([WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" })), WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" }))]) was not registered
FAILED sedonadb/tests/test_sjoin.py::test_spatial_join_geography[ST_Distance(sjoin_geog1.geog, sjoin_geog2.geog) < 100000-LEFT OUTER JOIN] - pyarrow.lib.ArrowInvalid: External error: This feature is not implemented: Implementation for st_distance([WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" })), WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" }))]) was not registered
FAILED sedonadb/tests/test_sjoin.py::test_spatial_join_geography[ST_Distance(sjoin_geog1.geog, sjoin_geog2.geog) < 100000-RIGHT OUTER JOIN] - pyarrow.lib.ArrowInvalid: External error: This feature is not implemented: Implementation for st_distance([WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" })), WkbView(Spherical, Some(AuthorityCode { authority: "OGC", code: "CRS84" }))]) was not registered
========================= 6 failed, 2188 passed, 18 skipped, 2 xfailed, 2 xpassed in 215.94s (0:03:35) =========================
Failed to verify release candidate. See /var/folders/97/h5r_bfwn6f98dlt3t8vm99t00000gn/T/sedonadb-0.2.0.XXXXXX.b2ewSsfIQn for details.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions