Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ST_CRS function to return the coordinate reference system (CRS) of a geometry, which complements the existing ST_SRID function by supporting non-EPSG codes.
- Implements
ST_CRSfunction that returns the full CRS object as a string - Adds comprehensive test coverage for the new function
- Registers the new function in the default function set
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rust/sedona-functions/src/st_srid.rs | Implements the core ST_CRS function logic and adds comprehensive unit tests |
| rust/sedona-functions/src/register.rs | Registers the new ST_CRS function in the default function set |
| python/sedonadb/tests/functions/test_transforms.py | Adds integration tests for both ST_SRID and ST_CRS functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
paleolimbot
reviewed
Sep 9, 2025
Member
paleolimbot
left a comment
There was a problem hiding this comment.
Great! Just a few minor comments!
paleolimbot
approved these changes
Sep 10, 2025
Member
paleolimbot
left a comment
There was a problem hiding this comment.
A few things to consider now or in a follow-up!
(Also the merge conflict so that CI can run!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding
ST_CRSso that we can pull the full CRS object from geometry where SRIDs do not apply (for example with non-EPSG codes).Issue: #29
Examples