feat(rust/sedona): Auto-configure spilled batch in-memory size threshold based on global memory limit#680
Merged
paleolimbot merged 2 commits intoapache:mainfrom Mar 4, 2026
Conversation
…old based on global memory limit
Contributor
There was a problem hiding this comment.
Pull request overview
Automatically derives Sedona’s spatial-join spill batching threshold from the configured DataFusion global memory limit, to reduce manual tuning when enabling spilling/memory limits.
Changes:
- Reads
RuntimeEnvmemory pool limit and computes a per-partition limit usingtarget_partitions. - Sets
sedona.spatial_join.spilled_batch_in_memory_size_thresholdto 5% of per-partition memory (min 10MB) when the memory limit is finite.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Merging so I can do a few tests! |
paleolimbot
pushed a commit
that referenced
this pull request
Mar 5, 2026
…old based on global memory limit (#680)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spilled_batch_in_memory_size_thresholdbased on the global memory limit, setting it to 5% of the per-partition memory limit (with a minimum of 10MB).Tests
We've tested running spatial join queries in SpatialBench SF=10 and 100, and also some spatial joins involving OvertureMaps datasets (address, building, landuse), and found that this default value worked pretty well. Users can still override the default value using
SET sedona.spatial_join.spilled_batch_in_memory_size_threshold = <custom_value>.