feat(python/sedonadb): Enable GPU feature in python package and add spatial join tests#768
Merged
Merged
Conversation
Member
|
@jiayuasu For Arrow we use https://runs-on.com/ for GPU runner support. I did think we already had this for our rust GPU jobs? https://github.com/apache/arrow-nanoarrow/blob/main/.github/workflows/build-and-test-device.yaml#L53 |
paleolimbot
approved these changes
Apr 16, 2026
Member
paleolimbot
left a comment
There was a problem hiding this comment.
Thank you! A few suggestions for tests that I don't think apply to the gpu join, and I think it would probably be good to add the __features__ while we're here, since this is a very cool one!
4d1dc5d to
ea0b543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We’ll eventually need a CI server with a GPU if we want to get serious about GPU support @jiayuasu @paleolimbot . Test results from my server are included below:
Note that this PR depends on #766, or the GPU join might not trigger correctly.