feat(rust/sedona-functions,c/sedona-proj): Support geography in CRS/SRID functions#848
Open
paleolimbot wants to merge 9 commits into
Open
feat(rust/sedona-functions,c/sedona-proj): Support geography in CRS/SRID functions#848paleolimbot wants to merge 9 commits into
paleolimbot wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Geography in functions that work with CRSes. There was limited support for Geography with item-crs but it had been excluded from ST_Transform and ST_SetSRID and the srid-setting shortcuts in ST_Point and friends.
This PR also validates target CRSes so that it's harder to specify an invalid crs in ST_SetSRID or ST_Transform. This isn't perfect...CRSes that contain an elevation aren't going to be validated here but there are workarounds (specify a 2D crs, which will leave the Z values intact, and restore the 3D crs on the trip back to geometry).
I'm not sure exaclty what the use case is for item crs with geography but it was easy enough to support here so I went for it. Supporting NAD83 is probably useful because I think the average radius over north america is slightly more accurate (but still not a replacement for true geodescic edge support).