[SEDONA-722] Fix precision loss problems caused by casting world coordinates from double to float #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kontinuation
commented
Mar 17, 2025
Comment on lines
+469
to
+473
| Point2D.Double gridCoord = new DirectPosition2D(colX - 1, rowY - 1); | ||
| return raster | ||
| .getGridGeometry() | ||
| .getGridToCRS2D(PixelOrientation.UPPER_LEFT) | ||
| .transform(new GridCoordinates2D(colX - 1, rowY - 1), null); | ||
| .transform(gridCoord, null); |
Member
Author
There was a problem hiding this comment.
GridCoordinates2D is not a subclass of Point2D.Double, so the result of transform will be Point2D.Float: https://github.com/openjdk/jdk/blob/jdk-17%2B35/src/java.desktop/share/classes/java/awt/geom/AffineTransform.java#L2899-L2906. We explicitly use Point2D.Double here to avoid loss of precision.
jiayuasu
approved these changes
Mar 17, 2025
jiayuasu
pushed a commit
that referenced
this pull request
May 30, 2025
…dinates from double to float (#1860)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
The world coordinates were silently casted from double to float when getting world coordinates from grid coordinates. This affects the precision of
RS_RasterToWorldCoord*,RS_PixelAsPolygon, etc.How was this patch tested?
Updated the expected results of tests to more precise coordinates.
Did this PR include necessary documentation updates?