-
Notifications
You must be signed in to change notification settings - Fork 746
[SEDONA-720] Refactor GeoPandas Series implementation #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-720] Refactor GeoPandas Series implementation #1917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
python/sedona/geopandas/geoseries.py:172
- [nitpick] Consider renaming the variable 'all_args' (which aggregates both positional and keyword parameters) to 'all_params' to more clearly indicate its purpose.
for k, v in kwargs.items():
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One QQ: What if the user wants to use any other geometry column than the first one in the schema? Because I see that we take the very first geometry column as input to the functions. Should we add a field that lets users pick the geometry column? This may not be the scope for this PR.
The GeoSeries (and Pandas Series) should only have one "column" that in geo should be geometry type. Though for GeoDataFrame (and Pandas DataFrame) they can have multiple geometry columns. We can use set_geometry on the dataframe, but it won't be necessary (needed) for GeoSeries. |
|
Understood, thank you! I think we should use either |
Did you read the Contributor Guide?
Is this PR related to a ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
This PR refactor the GeoSeries python wrapper so that the code can be simplified, e.g.,
How was this patch tested?
test_geoseries.py
Did this PR include necessary documentation updates?