Skip to content

Conversation

@oliverbeagley
Copy link
Contributor

Did you read the Contributor Guide?

Is this PR related to a ticket?

  • Yes, and the PR name follows the format [GH-XXX] my subject.

What changes were proposed in this PR?

Fixes #1931

I have moved the import of packaging.version.parse to the try-except block that geopandas is imported in, as packaging is already a dependency of geopandas

How was this patch tested?

Local test by successfully running

from sedona.spark import SedonaContext
import pyspark.sql.functions as sf


SedonaContext.create(spark)
spark.range(10).withColumn("geom", sf.expr("ST_POINT(id, id)")).show()

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@oliverbeagley
Copy link
Contributor Author

oliverbeagley commented Apr 30, 2025

I am in two minds about whether packaging should be added to the package dependencies as optional.

I haven't as it stands, and other areas of the code make similar decisions e.g. geoarrow, pyarrow, pyproj are not listed as optional dependencies anywhere but are all used in the code in python/sedona/utils/geoarrow.py.

@jiayuasu
Copy link
Member

@oliverbeagley I don't think we need to add packaging to optional dependencies because it is already a required dependency of GeoPandas. And currently it is only used for checking geopandas version. If geopandas is there, then packaging should be there too

@jiayuasu jiayuasu added the bug label Apr 30, 2025
@jiayuasu jiayuasu added this to the sedona-1.8.0 milestone Apr 30, 2025
@jiayuasu jiayuasu merged commit 9c0b1ba into apache:master Apr 30, 2025
26 checks passed
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hidden requirement for packaging in apache-sedona version 1.7.1

2 participants