[GH-1945] Shade Jiffle and its dependencies #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
approved these changes
May 30, 2025
jiayuasu
pushed a commit
that referenced
this pull request
May 30, 2025
Kontinuation
added a commit
to Kontinuation/sedona
that referenced
this pull request
Jan 21, 2026
* Shade jiffle and its dependencies * Fix lint warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject.What changes were proposed in this PR?
This PR shades jiffle into sedona-common to workaround problems encountered on runtimes with low janino version. Please refer to #1945 for details.
This PR is mostly taken from #1919, which shades jiffle and antlr. This PR shades janino additionally.
Jiffle should be removed from geotools-wrapper (see jiayuasu/geotools-wrapper#12), since now it is shaded into sedona-common and shipped with sedona-spark-shaded jar.
How was this patch tested?
Tested manually on DBR 15.4 LTS.
Did this PR include necessary documentation updates?